Skip to content

feat: add .apinotes support #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

feat: add .apinotes support #931

merged 1 commit into from
May 15, 2025

Conversation

rw-garmin
Copy link
Contributor

Short description 📝

API notes is a YAML based sidecar file that adds additional information for Swift interoperability with other languages. For framework based modules, it needs to be included in the headers list.
See Also: https://clang.llvm.org/docs/APINotes.html

Solution 📦

Add .apinotes to the supported headersExtensions list

fortmarek
fortmarek approved these changes May 2, 2025
View reviewed changes
Copy link
Member

@fortmarek fortmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go once the CI passes. Thanks @rw-garmin 🙌

@rw-garmin rw-garmin changed the title Add .apinotes support feat: Add .apinotes support May 2, 2025
@rw-garmin
Copy link
Contributor Author

@fortmarek - is there anything else I need to do?

@fortmarek fortmarek changed the title feat: Add .apinotes support feat: add .apinotes support May 15, 2025
@fortmarek fortmarek merged commit 05e0514 into tuist:main May 15, 2025
5 of 7 checks passed
@fortmarek
Copy link
Member

Thanks again for the PR 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fortmarek fortmarek fortmarek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rw-garmin @fortmarek